feat: Adds optionally moved blocks #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
commented
Feb 24, 2025
| Aliases: []string{"tf"}, | ||
| } | ||
| terraformCmd.AddCommand(clu2adv.Builder(), adv2.Builder()) | ||
| terraformCmd.AddCommand(clu2adv.Builder()) |
There was a problem hiding this comment.
remove skeleton for adv_cluster v1 to v2 conversion to avoid customer confusion as it won't be implemented yet
EspenAlbert
reviewed
Feb 24, 2025
| expectedErrContains: "file must not exist: " + fileExpected, | ||
| }, | ||
| "basic use": { | ||
| args: []string{"--file", fileIn, "--output", fileOut}, |
There was a problem hiding this comment.
good idea, added here: d0617be
EspenAlbert
reviewed
Feb 24, 2025
| } | ||
|
|
||
| resource "mongodbatlas_advanced_cluster" "forEach" { | ||
| # for_each doesn't affect moved blocks, it works in the same way |
There was a problem hiding this comment.
So this means it will handle all the dynamic values?
0 index and different keys?
There was a problem hiding this comment.
yes, moved will move state for all the indexes (including 0 that won't do anything but won't fail)
EspenAlbert
reviewed
Feb 24, 2025
| return false | ||
| } | ||
|
|
||
| func fillMovedBlocks(body *hclwrite.Body, moveLabels []string) { |
EspenAlbert
approved these changes
Feb 24, 2025
@EspenAlbert added here: a3b1635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds optionally moved blocks. It also adds skeleton for 2e2 tests, tests that execute the plugin binary.
Link to any related issue(s): CLOUDP-302368
Type of change:
Required Checklist:
Further comments