feat: Supports dynamic blocks in replication_specs #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
commented
Mar 20, 2025
| region_name = region.region_name | ||
| priority = region.priority | ||
| electable_specs = region.electable_nodes > 0 ? { | ||
| electable_specs = region.electable_nodes == 0 ? null : { |
There was a problem hiding this comment.
nit: easier to read as we only need to change the first line of the object but not the last one
There was a problem hiding this comment.
Is it possible that any of these are nullable? (electable_nodes, read_only_nodes, etc.)
There was a problem hiding this comment.
yes, read_only_nodes for sure, and in the latest PR I also allow electable_nodes to be null (e.g. a region only with read-only nodes)
There was a problem hiding this comment.
@lantoli, will the comparison crash if region.read_only_nodes are null?
lantoli
commented
Mar 20, 2025
| @@ -1,10 +1,9 @@ | |||
| { | |||
| "autoscaling_missing_attribute": "setting replication_specs: attribute provider_instance_size_name not found", | |||
There was a problem hiding this comment.
ordered alphabetically
marcosuma
reviewed
Mar 20, 2025
Co-authored-by: Marco Suma <[email protected]>
EspenAlbert
reviewed
Mar 20, 2025
README.md
Outdated
|
|
||
| - [`num_shards`](https://registry.terraform.io/providers/mongodb/mongodbatlas/latest/docs/resources/cluster#num_shards-2) in `replication_specs` must be a numeric [literal expression](https://developer.hashicorp.com/nomad/docs/job-specification/hcl2/expressions#literal-expressions), e.g. `var.num_shards` is not supported. This is to allow creating a `replication_specs` element per shard in `mongodbatlas_advanced_cluster`. This limitation doesn't apply if you're using `dynamic` blocks in `regions_config` or `replication_specs`. | ||
| - `dynamic` blocks are currently supported only for `tags`, `labels` and `regions_config`. See limitations for `regions_config` support in [its section](#dynamic-blocks-in-regions_config) above. **Coming soon**: support for `replication_specs`. | ||
| - `dynamic` blocks are supported with some limitations for [`regions_config`](#dynamic-blocks-in-regions_config) and [`replication_specs`](#dynamic-blocks-in-replication_specs). |
There was a problem hiding this comment.
Suggested change
| - `dynamic` blocks are supported with some limitations for [`regions_config`](#dynamic-blocks-in-regions_config) and [`replication_specs`](#dynamic-blocks-in-replication_specs). | |
| - `dynamic` blocks are supported with small limitations documented in [`regions_config`](#dynamic-blocks-in-regions_config) and [`replication_specs`](#dynamic-blocks-in-replication_specs). |
There was a problem hiding this comment.
Suggested change
| - `dynamic` blocks are supported with some limitations for [`regions_config`](#dynamic-blocks-in-regions_config) and [`replication_specs`](#dynamic-blocks-in-replication_specs). | |
| - `dynamic` blocks are supported with the limitations documented in [`regions_config`](#dynamic-blocks-in-regions_config) and [`replication_specs`](#dynamic-blocks-in-replication_specs). |
There was a problem hiding this comment.
@EspenAlbert @oarbusi at the end I've followed a different approach and created a guide: 919fc02
oarbusi
reviewed
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supports dynamic blocks in replication_specs.
Link to any related issue(s): CLOUDP-303941
Type of change:
Required Checklist:
Further comments