feat: Convert multi replication specs multi regions advanced clusters

internal/convert/adv2v2.go

@@ -1,6 +1,7 @@
 package convert
 
 import (
+	"fmt"
 	"slices"
 
 	"github.com/hashicorp/hcl/v2/hclwrite"
@@ -56,31 +57,45 @@ func updateResource(resource *hclwrite.Block) (bool, error) {
 }
 
 func convertRepSpecs(resourceb *hclwrite.Body) error {
-	block := resourceb.FirstMatchingBlock(nRepSpecs, nil)
-	if block == nil {
-		return nil
+	var repSpecs []*hclwrite.Body
+	for {
+		block := resourceb.FirstMatchingBlock(nRepSpecs, nil)
+		if block == nil {
+			break
+		}
+		resourceb.RemoveBlock(block)
+		if err := convertConfig(block.Body()); err != nil {
+			return err
+		}
+		repSpecs = append(repSpecs, block.Body())
 	}
-	resourceb.RemoveBlock(block)
-	if err := convertConfig(block.Body()); err != nil {
-		return err
+	if len(repSpecs) == 0 {
+		return fmt.Errorf("must have at least one replication_specs")
 	}
-	resourceb.SetAttributeRaw(nRepSpecs, hcl.TokensArraySingle(block.Body()))
+	resourceb.SetAttributeRaw(nRepSpecs, hcl.TokensArray(repSpecs))
 	return nil
 }
 
 func convertConfig(repSpecs *hclwrite.Body) error {
-	block := repSpecs.FirstMatchingBlock(nConfig, nil)
-	if block == nil {
-		return nil
+	var configs []*hclwrite.Body
+	for {
+		block := repSpecs.FirstMatchingBlock(nConfig, nil)
+		if block == nil {
+			break
+		}
+		repSpecs.RemoveBlock(block)
+		blockb := block.Body()
+		fillBlockOpt(blockb, nElectableSpecs)
+		fillBlockOpt(blockb, nReadOnlySpecs)
+		fillBlockOpt(blockb, nAnalyticsSpecs)
+		fillBlockOpt(blockb, nAutoScaling)
+		fillBlockOpt(blockb, nAnalyticsAutoScaling)
+		configs = append(configs, blockb)
+	}
+	if len(configs) == 0 {
+		return fmt.Errorf("replication_specs must have at least one region_configs")
 	}
-	repSpecs.RemoveBlock(block)
-	blockb := block.Body()
-	fillBlockOpt(blockb, nElectableSpecs)
-	fillBlockOpt(blockb, nReadOnlySpecs)
-	fillBlockOpt(blockb, nAnalyticsSpecs)
-	fillBlockOpt(blockb, nAutoScaling)
-	fillBlockOpt(blockb, nAnalyticsAutoScaling)
-	repSpecs.SetAttributeRaw(nConfig, hcl.TokensArraySingle(blockb))
+	repSpecs.SetAttributeRaw(nConfig, hcl.TokensArray(configs))
 	return nil
 }
 

internal/convert/testdata/adv2v2/choose_sources.in.tf

@@ -1,5 +1,17 @@
 resource "mongodbatlas_advanced_cluster" "this" {
   # updated, doesn't have nested attributes
+
+  replication_specs {
+    region_configs {
+      priority      = 7
+      provider_name = "AWS"
+      region_name   = "EU_WEST_1"
+      electable_specs {
+        instance_size = "M10"
+        node_count    = 3
+      }
+    }
+  }
 }
 
 resource "mongodbatlas_advanced_cluster" "this" {

internal/convert/testdata/adv2v2/choose_sources.out.tf

@@ -1,6 +1,22 @@
 resource "mongodbatlas_advanced_cluster" "this" {
   # updated, doesn't have nested attributes
 
+  replication_specs = [
+    {
+      region_configs = [
+        {
+          priority      = 7
+          provider_name = "AWS"
+          region_name   = "EU_WEST_1"
+          electable_specs = {
+            instance_size = "M10"
+            node_count    = 3
+          }
+        }
+      ]
+    }
+  ]
+
   # Updated by atlas-cli-plugin-terraform, please review the changes.
 }
 

internal/convert/testdata/adv2v2/errors.json

@@ -1,3 +1,5 @@
 {
-	"configuration_file_error": "failed to parse Terraform config file"
+	"configuration_file_error": "failed to parse Terraform config file",
+	"replication_specs_missing_region_configs": "replication_specs must have at least one region_configs",
+	"missing_replication_specs": "must have at least one replication_specs"
 }

internal/convert/testdata/adv2v2/flex.in.tf

@@ -0,0 +1,14 @@
+resource "mongodbatlas_advanced_cluster" "this" {
+  project_id   = "<YOUR-PROJECT-ID>"
+  name         = "flex-cluster"
+  cluster_type = "REPLICASET"
+
+  replication_specs {
+    region_configs {
+      provider_name         = "FLEX"
+      backing_provider_name = "AWS"
+      region_name           = "US_EAST_1"
+      priority              = 7
+    }
+  }
+}

internal/convert/testdata/adv2v2/flex.out.tf

@@ -0,0 +1,20 @@
+resource "mongodbatlas_advanced_cluster" "this" {
+  project_id   = "<YOUR-PROJECT-ID>"
+  name         = "flex-cluster"
+  cluster_type = "REPLICASET"
+
+  replication_specs = [
+    {
+      region_configs = [
+        {
+          provider_name         = "FLEX"
+          backing_provider_name = "AWS"
+          region_name           = "US_EAST_1"
+          priority              = 7
+        }
+      ]
+    }
+  ]
+
+  # Updated by atlas-cli-plugin-terraform, please review the changes.
+}

internal/convert/testdata/adv2v2/missing_replication_specs.in.tf

@@ -0,0 +1,6 @@
+resource "mongodbatlas_advanced_cluster" "no_replication_specs" {
+  # missing replication_specs
+  project_id   = var.project_id
+  name         = "cluster-multi-region"
+  cluster_type = "REPLICASET"
+}

internal/convert/testdata/adv2v2/multi_region.in.tf

@@ -0,0 +1,39 @@
+resource "mongodbatlas_advanced_cluster" "multi_region" {
+  project_id     = var.project_id
+  name           = "cluster-multi-region"
+  cluster_type   = "REPLICASET"
+  backup_enabled = true
+
+  replication_specs {
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_EAST_1"
+      priority      = 7
+      electable_specs = {
+        node_count    = 3
+        instance_size = "M10"
+        disk_size_gb  = 100
+      }
+    }
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_WEST_2"
+      priority      = 6
+      electable_specs = {
+        node_count    = 3
+        instance_size = "M10"
+        disk_size_gb  = 100
+      }
+    }
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_WEST_1"
+      priority      = 5
+      electable_specs = {
+        node_count    = 1
+        instance_size = "M10"
+        disk_size_gb  = 100
+      }
+    }
+  }
+}

internal/convert/testdata/adv2v2/multi_region.out.tf

@@ -0,0 +1,45 @@
+resource "mongodbatlas_advanced_cluster" "multi_region" {
+  project_id     = var.project_id
+  name           = "cluster-multi-region"
+  cluster_type   = "REPLICASET"
+  backup_enabled = true
+
+  replication_specs = [
+    {
+      region_configs = [
+        {
+          provider_name = "AWS"
+          region_name   = "US_EAST_1"
+          priority      = 7
+          electable_specs = {
+            node_count    = 3
+            instance_size = "M10"
+            disk_size_gb  = 100
+          }
+        },
+        {
+          provider_name = "AWS"
+          region_name   = "US_WEST_2"
+          priority      = 6
+          electable_specs = {
+            node_count    = 3
+            instance_size = "M10"
+            disk_size_gb  = 100
+          }
+        },
+        {
+          provider_name = "AWS"
+          region_name   = "US_WEST_1"
+          priority      = 5
+          electable_specs = {
+            node_count    = 1
+            instance_size = "M10"
+            disk_size_gb  = 100
+          }
+        }
+      ]
+    }
+  ]
+
+  # Updated by atlas-cli-plugin-terraform, please review the changes.
+}

internal/convert/testdata/adv2v2/multi_replication_specs.in.tf

@@ -0,0 +1,104 @@
+resource "mongodbatlas_advanced_cluster" "multirep" {
+  project_id     = var.project_id
+  name           = "multirep"
+  cluster_type   = "GEOSHARDED"
+  backup_enabled = false
+  replication_specs {
+    zone_name = "Zone 1"
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_EAST_1"
+      priority      = 7
+      electable_specs {
+        node_count    = 3
+        instance_size = "M10"
+        disk_size_gb  = 80
+      }
+    }
+  }
+  replication_specs {
+    zone_name = "Zone 2"
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_WEST_2"
+      priority      = 7
+      electable_specs {
+        node_count    = 3
+        instance_size = "M10"
+        disk_size_gb  = 80
+      }
+    }
+  }
+}
+
+resource "mongodbatlas_advanced_cluster" "geo" {
+  project_id     = var.project_id
+  name           = "geo"
+  cluster_type   = "GEOSHARDED"
+  backup_enabled = false
+  replication_specs {
+    zone_name = "Zone 1"
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_EAST_1"
+      priority      = 7
+      electable_specs {
+        node_count    = 3
+        instance_size = "M10"
+        disk_size_gb  = 80
+      }
+    }
+  }
+  replication_specs {
+    zone_name = "Zone 1"
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_EAST_1"
+      priority      = 7
+      electable_specs {
+        node_count    = 3
+        instance_size = "M10"
+        disk_size_gb  = 80
+      }
+    }
+  }
+  replication_specs {
+    zone_name = "Zone 2"
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_WEST_2"
+      priority      = 7
+      electable_specs {
+        node_count    = 3
+        instance_size = "M10"
+        disk_size_gb  = 80
+      }
+    }
+  }
+  replication_specs {
+    zone_name = "Zone 2"
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_WEST_2"
+      priority      = 7
+      electable_specs {
+        node_count    = 3
+        instance_size = "M10"
+        disk_size_gb  = 80
+      }
+    }
+  }
+  replication_specs {
+    zone_name = "Zone 2"
+    region_configs {
+      provider_name = "AWS"
+      region_name   = "US_WEST_2"
+      priority      = 7
+      electable_specs {
+        node_count    = 3
+        instance_size = "M10"
+        disk_size_gb  = 80
+      }
+    }
+  }
+}