chore: Initial plugin command #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
commented
Jan 10, 2025
| @@ -0,0 +1,55 @@ | |||
| CLI_SOURCE_FILES?=./cmd/plugin | |||
There was a problem hiding this comment.
using Makefile instead of GNUmakefile as we don't need specific features
lantoli
commented
Jan 13, 2025
| @@ -1,7 +1,6 @@ | |||
| --- | |||
| name: Create JIRA ticket for new issues | |||
| name: JIRA Tickets for GH Issues | |||
There was a problem hiding this comment.
common naming convention for GH actions
lantoli
commented
Jan 13, 2025
| .PHONY: clean | ||
| clean: ## Clean binary folders | ||
| rm -rf ./bin ./bin-plugin | ||
|
|
There was a problem hiding this comment.
local make target
EspenAlbert
reviewed
Jan 13, 2025
| ) | ||
|
|
||
| completionOption := &cobra.CompletionOptions{ | ||
| DisableDefaultCmd: true, |
There was a problem hiding this comment.
using the same defaults as in example and kubernetes plugins
EspenAlbert
reviewed
Jan 13, 2025
EspenAlbert
reviewed
Jan 13, 2025
EspenAlbert
reviewed
Jan 13, 2025
| commands: | ||
| terraform: | ||
| description: Utilities for Terraform's MongoDB Atlas Provider | ||
| tf: |
There was a problem hiding this comment.
love the shorthand option tf
EspenAlbert
reviewed
Jan 13, 2025
| description: Utilities for Terraform's MongoDB Atlas Provider | ||
| version: $VERSION | ||
| github: | ||
| owner: $GITHUB_REPOSITORY_OWNER |
There was a problem hiding this comment.
nice usage of env-vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial plugin command with release workflow.
Link to any related issue(s): CLOUDP-293949
Type of change:
Required Checklist:
Further comments