Skip to content

Conversation

oarbusi
Copy link
Contributor

@oarbusi oarbusi commented Sep 15, 2025

Description

Fixes SSDLC report generation to use the correct template that lives in the TF repo

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi marked this pull request as ready for review September 16, 2025 06:55
@oarbusi oarbusi requested a review from a team as a code owner September 16, 2025 06:55
@Copilot Copilot AI review requested due to automatic review settings September 16, 2025 06:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the SSDLC report generation by updating the workflow to use the correct template from the terraform-provider-mongodbatlas repository instead of a local template.

  • Updates the checkout step to fetch the terraform-provider-mongodbatlas repository
  • Changes the template reference to use the external repository's template

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

with:
repository: mongodb/terraform-provider-mongodbatlas
ref: master
- uses: mongodb/terraform-provider-mongodbatlas/.github/templates/run-script-and-commit@master
Copy link

Copilot AI Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using '@master' as a reference is not recommended for production workflows as it can introduce unpredictable changes. Consider pinning to a specific commit SHA or using a tagged version for better stability and reproducibility.

Suggested change
- uses: mongodb/terraform-provider-mongodbatlas/.github/templates/run-script-and-commit@master
- uses: mongodb/terraform-provider-mongodbatlas/.github/templates/run-script-and-commit@e2e2b7e2e2e2e2e2e2e2e2e2e2e2e2e2e2e2e2e2

Copilot uses AI. Check for mistakes.

@oarbusi oarbusi merged commit 03b3b5e into main Sep 16, 2025
9 checks passed
@oarbusi oarbusi deleted the fix-ssdlc branch September 16, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants