-
Notifications
You must be signed in to change notification settings - Fork 70
PYTHON-5157 Convert aws tests to use python scripts #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ols into aws-output-file
…ols into aws-output-file
…ols into aws-output-file
…ols into aws-output-file
if e.code == 404: | ||
return False | ||
print(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a logger instead of a print?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tested with mongodb/mongo-python-driver#2180. https://spruce.mongodb.com/version/67c70e769f12c60007ecf424/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
Tested with Go driver: https://spruce.mongodb.com/version/67c70ea9829c1400078d228b/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC
We need to write the creds to a file since we're running the script from Python instead of Bash.