Skip to content

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 10, 2025

Tested with mongodb/mongo-python-driver#2190: https://spruce.mongodb.com/version/67cc94d4b26dff000739c152/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

and the C driver: https://spruce.mongodb.com/version/67ced2d64d80c40007a73649/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC

Uses waitress to create a production flask server that can be run as a daemon on all platforms.
Adds tests for OCSP server on Mac, Windows, and RHEL.

@blink1073 blink1073 merged commit cfa2a5a into mongodb-labs:master Mar 10, 2025
75 checks passed
@blink1073 blink1073 deleted the ocsp-updates branch March 10, 2025 13:59
@jmikola
Copy link
Contributor

jmikola commented Mar 12, 2025

Adds tests for OCSP server on Mac, Windows, and RHEL

@blink1073: I noted that this wasn't tested on Debian 12 hosts, but are you aware of any workaround for the following error when launching the OCSP responder?

oscrypto.errors.LibraryNotFoundError: Error detecting the version of libcrypto

See: PHPC task failure for more context.

I think this can be traced back to wbond/oscrypto#78 and there appear to be some suggested workarounds that depend on a specific commit since it looks like the fix has yet to be tagged.

If that's not feasible, I can look into switching our OCSP tasks over to a different platform.

@@ -4,5 +4,6 @@ flask==2.2.5
itsdangerous==2.1.2
Jinja2==3.1.5
MarkupSafe==2.1.4
git+https://github.com/wbond/oscrypto.git@d5f3437
Copy link
Contributor

@jmikola jmikola Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073: This removal is what appears to have caused the regression in PHPC. I noticed that this commit was mentioned in wbond/oscrypto#78 (comment) as a workaround for the upstream issue with oscrypto 1.3.0.

The original context for this change was #452, but it looks like we'd do well to include a comment here for future reference. Might be a good idea to reference the upstream issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I had removed the specific tag because I was seeing a warning from pip. I'll revert to use the tag.

jmikola added a commit that referenced this pull request Mar 12, 2025
This was previously added in #452 but inadvertently reverted in #626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants