-
Notifications
You must be signed in to change notification settings - Fork 70
DRIVERS-3254: Add perfcomp to drivers-evergreen-tools #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a6749a7
to
7f71583
Compare
So far so good, I ran it against a patch build:
I'll see if I can find a build that does have a change point. |
I'd also suggest adding a |
@blink1073 Added |
I purposely caused a slowdown in bson encoding/decoding, and verified that the benchmark went from bout 100 to 7 Mbps for DeepEncoding, but did not get a result.
|
@blink1073 did you create a performance context for the python driver? this is needed to filter for all the python project data, it might also take a few hours for the data to be tagged. If not I can also create the context and test it out for python driver! |
Okay, I'll wait and try later. I targeted this context: https://performance-monitoring-and-analysis.server-tig.prod.corp.mongodb.com/context/name/PyMongo%20Perf. |
ahh I believe thats a time series context, the performance context needs to be a triage context specifically. sorry for not specifying! if you could target a triage context that already exists it should work, if you make a new triage context that may take a few hours. I'll add that to the README for clarity |
Okay, I created https://performance-monitoring-and-analysis.server-tig.prod.corp.mongodb.com/context/name/PyMongo%20triage%20context. I'll try that one later. 😄 |
Looking good for Python!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
DRIVERS-3254
Move perfcomp from Go Driver to DET.