[Draft] CLI options should override Env vars and allow custom orchestration file #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
reviewed
Sep 23, 2025
| mo_config = mo_home / "orchestration.config" | ||
| mdb_binaries = Path(opts.mongodb_binaries) | ||
| config = dict(releases=dict(default=normalize_path(mdb_binaries))) | ||
| mo_config.write_text(json.dumps(config, indent=2)) |
There was a problem hiding this comment.
It might be useful here to detect whether this overwrites an existing (nonidentical) configuration and warn if so. That way if someone forgets the --custom-mo-config parameter, the log will guide the way to success.
There was a problem hiding this comment.
That's the problem though, we create it every time we run, so when running locally it would error out.
|
@FGasper have you had a chance to test these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.