Skip to content

Conversation

@blink1073
Copy link
Member

Adds support for zizmor, "a tool for finding security issues in GitHub Actions CI/CD setups."
It is still in development, but already useful. Missing features are a GitHub Action, and a non-zero exit code so we can fail builds. For now this applies the recommended fixes and sets it up as a security scan source.

@blink1073 blink1073 requested a review from alcaeus November 4, 2024 14:00
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Collaborator

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to add checks for GitHub Actions. Just one question about the create-branch content.

is set to anything other than `false`, no files are uploaded, but instead the
filename along with the resulting location in the bucket is printed.

## Create Release Branch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't this already added by #59?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drat, forgot to create a new branch, reverting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, pulling from main resolved it.

@blink1073 blink1073 requested a review from alcaeus November 4, 2024 14:58
@blink1073 blink1073 merged commit 7bec72b into mongodb-labs:main Nov 4, 2024
5 checks passed
@blink1073 blink1073 deleted the branch-update-script branch November 4, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants