-
Notifications
You must be signed in to change notification settings - Fork 8
Adopt zizmor GitHub Actions security scanning tool #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
alcaeus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea to add checks for GitHub Actions. Just one question about the create-branch content.
| is set to anything other than `false`, no files are uploaded, but instead the | ||
| filename along with the resulting location in the bucket is printed. | ||
|
|
||
| ## Create Release Branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't this already added by #59?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drat, forgot to create a new branch, reverting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, pulling from main resolved it.
…nto branch-update-script
Adds support for zizmor, "a tool for finding security issues in GitHub Actions CI/CD setups."
It is still in development, but already useful. Missing features are a GitHub Action, and a non-zero exit code so we can fail builds. For now this applies the recommended fixes and sets it up as a security scan source.