build(NODE-6598): fix node signing action for all node team packages #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
addaleax
approved these changes
Dec 9, 2024
Collaborator
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
I'd probably have kept this as a bash script (the find command in particular should be able to handle this very well) but either way, as long as it solves a problem, the code here looks good
addaleax
reviewed
Dec 9, 2024
addaleax
approved these changes
Dec 9, 2024
baileympearson
force-pushed
the
fle-expansions
branch
from
3e690cc to
8ed49b9
Compare
nbbeeken
added
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64 updated the Node team's signing action to account for npm scopes. For some reason, the expansion works with npm scopes but fails for packages without (all packages except for zstd).
This step looks for all built artifacts before signing them.
I decided to rewrite this logic into a small node script instead.passing in zstd: https://github.com/mongodb-js/zstd/actions/runs/12240392950
passing in mongodb-client-encryption: https://github.com/mongodb-js/mongodb-client-encryption/actions/runs/12240610213/job/34151543294