Skip to content

Conversation

@blink1073 blink1073 requested a review from alcaeus April 28, 2025 13:57
@blink1073 blink1073 marked this pull request as ready for review April 28, 2025 13:57
@alcaeus
Copy link
Collaborator

alcaeus commented May 5, 2025

Sorry I missed this PR. What's the reason for pinning these actions? This would also prevent dependabot from submitting updates for actions, as it can't handle actions that are pinned to a specific commit.

@blink1073
Copy link
Member Author

It is considered best practice by GitHub and Zizmor, and is documented to work with dependabot:

"Pin actions to a full length commit SHA"

https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions

"For each action in the file, Dependabot checks the action's reference (typically a version number or commit identifier associated with the action) against the latest version"

https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot#about-dependabot-version-updates-for-actions

Copy link
Collaborator

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification, LGTM.

I recently checked support for Dependabot updates on actions with a commit hash and was under the impression that it doesn't work - let's see if updates work correctly.

@blink1073 blink1073 merged commit fcb2cd5 into mongodb-labs:main May 6, 2025
5 checks passed
@blink1073 blink1073 deleted the pin-actions branch May 6, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants