Skip to content

feat: Adds support for new attributes for Trigger configuration #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 25, 2025
Merged

feat: Adds support for new attributes for Trigger configuration #6

merged 9 commits into from
Feb 25, 2025

Conversation

@maastha
Copy link
Collaborator

@maastha maastha commented Feb 21, 2025 •
edited
Loading

Proposed changes

Adds below attributes to Trigger Configuration:

  • TolerateResumeErrors
  • SkipCatchupEvents
  • MaximumThroughput

Jira ticket: CLOUDP-273338

Checklist

  • I have signed the MongoDB CLA
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] I have added any necessary documentation (if appropriate)
  • [] I have run make fmt and formatted my code

Further comments

@maastha maastha requested a review from a team as a code owner February 21, 2025 18:40
@maastha maastha changed the base branch from main to release-workflow-init February 21, 2025 18:41
Base automatically changed from release-workflow-init to main February 24, 2025 09:58
marcosuma
marcosuma reviewed Feb 25, 2025
View reviewed changes
.github/pull_request_template.md
## Proposed changes

<!--
<!-- s
Copy link
Collaborator

@marcosuma marcosuma Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional?

@oarbusi
Copy link
Collaborator

oarbusi commented Feb 25, 2025

Seems like the PR has the changes of #5 , could we maybe rebase so that only the relevant changes are in this PR?

@maastha maastha merged commit 258410c into main Feb 25, 2025
2 checks passed
@maastha maastha deleted the trigger-new-attr branch February 25, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcosuma marcosuma marcosuma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maastha @oarbusi @marcosuma