Skip to content

Commit 8b058fb

Browse files
committed
fix lock
1 parent a1c1d0c commit 8b058fb

File tree

1 file changed

+21
-8
lines changed

1 file changed

+21
-8
lines changed

internal/verifier/recheck_test.go

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ func (suite *MultiMetaVersionTestSuite) TestLargeDataInsertions() {
156156
id3 := "c"
157157
ids := []interface{}{id1, id2, id3}
158158
dataSizes := []int{400 * 1024, 700 * 1024, 1024}
159-
err := verifier.insertRecheckDocsUnderLock(ctx, "testDB", "testColl", ids, dataSizes)
159+
err := insertRecheckDocs(ctx, verifier, "testDB", "testColl", ids, dataSizes)
160160
suite.Require().NoError(err)
161161
d1 := RecheckDoc{
162162
PrimaryKey: RecheckPrimaryKey{
@@ -217,13 +217,13 @@ func (suite *MultiMetaVersionTestSuite) TestMultipleNamespaces() {
217217
id3 := "c"
218218
ids := []interface{}{id1, id2, id3}
219219
dataSizes := []int{1000, 1000, 1000}
220-
err := verifier.insertRecheckDocsUnderLock(ctx, "testDB1", "testColl1", ids, dataSizes)
220+
err := insertRecheckDocs(ctx, verifier, "testDB1", "testColl1", ids, dataSizes)
221221
suite.Require().NoError(err)
222-
err = verifier.insertRecheckDocsUnderLock(ctx, "testDB1", "testColl2", ids, dataSizes)
222+
err = insertRecheckDocs(ctx, verifier, "testDB1", "testColl2", ids, dataSizes)
223223
suite.Require().NoError(err)
224-
err = verifier.insertRecheckDocsUnderLock(ctx, "testDB2", "testColl1", ids, dataSizes)
224+
err = insertRecheckDocs(ctx, verifier, "testDB2", "testColl1", ids, dataSizes)
225225
suite.Require().NoError(err)
226-
err = verifier.insertRecheckDocsUnderLock(ctx, "testDB2", "testColl2", ids, dataSizes)
226+
err = insertRecheckDocs(ctx, verifier, "testDB2", "testColl2", ids, dataSizes)
227227
suite.Require().NoError(err)
228228

229229
verifier.generation++
@@ -267,17 +267,17 @@ func (suite *MultiMetaVersionTestSuite) TestGenerationalClear() {
267267
id2 := "b"
268268
ids := []interface{}{id1, id2}
269269
dataSizes := []int{1000, 1000}
270-
err := verifier.insertRecheckDocsUnderLock(ctx, "testDB", "testColl", ids, dataSizes)
270+
err := insertRecheckDocs(ctx, verifier, "testDB", "testColl", ids, dataSizes)
271271
suite.Require().NoError(err)
272272

273273
verifier.generation++
274274

275-
err = verifier.insertRecheckDocsUnderLock(ctx, "testDB", "testColl", ids, dataSizes)
275+
err = insertRecheckDocs(ctx, verifier, "testDB", "testColl", ids, dataSizes)
276276
suite.Require().NoError(err)
277277

278278
verifier.generation++
279279

280-
err = verifier.insertRecheckDocsUnderLock(ctx, "testDB", "testColl", ids, dataSizes)
280+
err = insertRecheckDocs(ctx, verifier, "testDB", "testColl", ids, dataSizes)
281281
suite.Require().NoError(err)
282282

283283
d1 := RecheckDoc{
@@ -326,3 +326,16 @@ func (suite *MultiMetaVersionTestSuite) TestGenerationalClear() {
326326
results = suite.fetchRecheckDocs(ctx, verifier)
327327
suite.ElementsMatch([]interface{}{}, results)
328328
}
329+
330+
func insertRecheckDocs(
331+
ctx context.Context,
332+
verifier *Verifier,
333+
dbName, collName string,
334+
documentIDs []any,
335+
dataSizes []int,
336+
) error {
337+
verifier.mux.Lock()
338+
defer verifier.mux.Unlock()
339+
340+
return verifier.insertRecheckDocsUnderLock(ctx, dbName, collName, documentIDs, dataSizes)
341+
}

0 commit comments

Comments
 (0)