REP-6804 Simplify change handling logic #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
changed the title
tdq45gj
reviewed
Nov 12, 2025
Comment on lines
+38
to
+42
| select { | ||
| case <-e.ready: | ||
| return e.val | ||
| default: | ||
| panic("Eventual's Get() called before value was ready.") |
Collaborator
There was a problem hiding this comment.
It seems that Eventual can only be read once per write. The comment says it's like context.Context’s Done() and Err(), is that changed with this PR?
Collaborator
Author
There was a problem hiding this comment.
I added a test that confirms that a 2nd time works.
Collaborator
Author
There was a problem hiding this comment.
It’s not changed … I added a test that confirms that a 2nd read works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code maintained:
This is overly complex.
This changeset simplifies the above. Now there is a single Eventual that holds the final status of both readers & both persistors. Together the reader & persistor threads are called “change handling”.
This also fixes a small bug in Eventual: previously it was impossible to store a nil value because Eventual was implemented via Option. Now it’s possible to store nil.