Skip to content

Add a timeout when reading cursor, and fail immediately. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

Add a timeout when reading cursor, and fail immediately. #46

merged 2 commits into from
Nov 18, 2024

Conversation

@FGasper
Copy link
Collaborator

@FGasper FGasper commented Nov 18, 2024

In certain cases reads from the source or destination seem to hang. This changeset makes two changes to address that:

  1. A timer is added to detect hung reads. It is hard-coded at 10 minutes, which seems conservative enough.
  2. The comparer thread fails immediately if it finds a failure from the source. Previously it would read from the destination if the source failed. (This could be the case of the apparent hangs, but how that could be seems unclear.)

@FGasper FGasper requested a review from tdq45gj November 18, 2024 14:22
tdq45gj
tdq45gj approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@tdq45gj tdq45gj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FGasper FGasper merged commit a1945d7 into mongodb-labs:main Nov 18, 2024
5 checks passed
@FGasper FGasper deleted the add_cursor_timeout branch November 18, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdq45gj tdq45gj tdq45gj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FGasper @tdq45gj