REP-5317 Ignore mongosync DBs on destination. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdq45gj
approved these changes
Dec 4, 2024
Collaborator
tdq45gj
left a comment
tdq45gj
left a comment
There was a problem hiding this comment.
LGTM, thanks for this fix!
FGasper
changed the title
FGasper
force-pushed
the
felipe_ignore_mongosync_dbs
branch
from
4e74fc4 to
348d004
Compare
This fixes an oversight from PR mongodb-labs#53. It also “upgrades” the test for the change stream filter to focus on behavior rather than implementation.
FGasper
force-pushed
the
felipe_ignore_mongosync_dbs
branch
from
e58478a to
41f973e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEWER NOTE: The first couple commits here are general cleanup. This PR will be merged via rebase.
To make migration-verifier’s change stream work with mongosync CI we need to ignore mongosync’s internal databases, which mongosync will manipulate alongside migration-verifier.
This changeset adjusts the change stream logic accordingly.