Add change stream lag to periodic progress reports. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdq45gj
approved these changes
Dec 4, 2024
| dstLag, hasDstLag := verifier.dstChangeStreamReader.GetLag().Get() | ||
| if hasDstLag { | ||
| if !hasSrcLag { | ||
| builder.WriteString("\n") |
Collaborator
There was a problem hiding this comment.
It seems that src and dst lags are adding the new line differently. Not sure if it's intentional.
Collaborator
Author
There was a problem hiding this comment.
There should always be a single newline in front of the lag-report lines. So if there was a source lag then there’s no need for one before the dst lag, but if there wasn’t a source lag then the dst lag has to have one.
FGasper
added a commit
that referenced
this pull request
Dec 11, 2024
The previous logic (PR #74) was backwards, which caused uint overflow. This adds a test that usually passes without this change but should occasionally fail. (It should always pass, though, with this change.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a report of change stream lags to the logs’ progress reports.