Skip to content

INTPYTHON-490 Fix segmentation fault when document doesn't match schema #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025
Merged

INTPYTHON-490 Fix segmentation fault when document doesn't match schema #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6eb6f7b
INTPYTHON-458 Fix macos wheel build for python 3.9
blink1073 Dec 18, 2024
beec5ff
INTPYTHON-490 Fix segmentation fault when document doesn't match schema
blink1073 Jan 21, 2025
6afef96
Merge branch 'main' of github.com:mongodb-labs/mongo-arrow into INTPY…
blink1073 Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bindings/python/pymongoarrow/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,12 @@ cdef class BuilderManager:
raise ValueError("Could not append raw value to", full_key.decode('utf8'))

# Recurse into documents.
if value_t == BSON_TYPE_DOCUMENT:
if value_t == BSON_TYPE_DOCUMENT and builder.type_marker == BSON_TYPE_DOCUMENT:
bson_iter_recurse(doc_iter, &child_iter)
self.parse_document(&child_iter, full_key, BSON_TYPE_DOCUMENT)

# Recurse into arrays.
if value_t == BSON_TYPE_ARRAY:
if value_t == BSON_TYPE_ARRAY and builder.type_marker == BSON_TYPE_ARRAY:
bson_iter_recurse(doc_iter, &child_iter)
self.parse_document(&child_iter, full_key, BSON_TYPE_ARRAY)

Expand Down
6 changes: 6 additions & 0 deletions bindings/python/test/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,12 @@ def test_schema_missing_field(self):
out = func(self.coll, {} if func == find_arrow_all else [], schema=schema).drop(["_id"])
self.assertEqual(out["list_field"].to_pylist(), expected)

def test_schema_incorrect_data_type(self):
self.coll.delete_many({})
self.coll.insert_one({"x": {"y": 1}})
out = find_arrow_all(self.coll, {}, schema=Schema({"x": str}))
assert out.to_pylist() == [{"x": None}]

def test_auto_schema_nested(self):
# Create table with random data of various types.
_, data = self._create_nested_data()
Expand Down
Loading