Skip to content

INTPYTHON-493 Fix handling of nulls in arrays #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2025
Merged

INTPYTHON-493 Fix handling of nulls in arrays #263

merged 2 commits into from
Jan 22, 2025
+252 −19

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented Jan 22, 2025

Fixes #257. Fixes #258.

@blink1073 blink1073 requested a review from aclark4life January 22, 2025 14:46
@blink1073 blink1073 requested a review from a team as a code owner January 22, 2025 14:46
@blink1073 blink1073 mentioned this pull request Jan 22, 2025
Closed
aclark4life
aclark4life approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@aclark4life aclark4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, so add

  • parent_names
  • parent_type

and check parent_type on iteration to store null values in the right place ? LGTM

@blink1073
Copy link
Member Author

blink1073 commented Jan 22, 2025

The root bug was that we were using the top level document count to handle missing values, but that is not valid for nested documents, where missing values are dependent on how many parent documents there are.

@blink1073
Copy link
Member Author

blink1073 commented Jan 22, 2025

Separately, we we not handling null values in lists properly, resulting in an empty list entry where it should have been None in the final Python list.

@blink1073 blink1073 merged commit c74c9a6 into mongodb-labs:main Jan 22, 2025
43 of 44 checks passed
@blink1073 blink1073 deleted the better-nested-nulls branch January 22, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aclark4life aclark4life aclark4life approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optional fields on pyarrow structs triggers error Incorrect null and missing value handling in nested data

2 participants

@blink1073 @aclark4life