Skip to content

DRIVERS-3256 Fix PortPool uniqueness when used in multiple threads #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2025
Merged

DRIVERS-3256 Fix PortPool uniqueness when used in multiple threads #320

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f0043a
DRIVERS-3256 Make Singleton thread safe to fix PortPool uniqueness
ShaneHarvey Aug 27, 2025
37a4963
DRIVERS-3256 Make PortPool constructor and port() methods thread safe…
ShaneHarvey Aug 27, 2025
3127b04
DRIVERS-3256 Bump 0.11.1
ShaneHarvey Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions mongo_orchestration/singleton.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/python
# coding=utf-8
# Copyright 2012-2014 MongoDB, Inc.
# Copyright 2012-2025 MongoDB, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -13,12 +13,14 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import threading

class Singleton(object):
_instances = {}
_lock = threading.Lock()

def __new__(class_, *args, **kwargs):
if class_ not in class_._instances:
class_._instances[class_] = super(Singleton, class_).__new__(class_, *args, **kwargs)
return class_._instances[class_]
with class_._lock:
if class_ not in class_._instances:
class_._instances[class_] = super(Singleton, class_).__new__(class_, *args, **kwargs)
return class_._instances[class_]