Skip to content

chore: Upgrades golangci-lint to v2 #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2025
Merged

chore: Upgrades golangci-lint to v2 #556

merged 3 commits into from
Mar 28, 2025

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Mar 28, 2025 •
edited
Loading

Description

Upgrades golangci-lint to v2 using the migration guide, follow example in: mongodb/openapi#616

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

lantoli
lantoli commented Mar 28, 2025
View reviewed changes
auth/clientcredentials/clientcredentials.go
"context"
"errors"
"fmt"
"golang.org/x/oauth2"
Copy link
Member Author

@lantoli lantoli Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes: File is not properly formatted (goimports)

@lantoli lantoli marked this pull request as ready for review March 28, 2025 10:23
@lantoli lantoli requested a review from a team as a code owner March 28, 2025 10:23
@lantoli lantoli merged commit b7f91e1 into main Mar 28, 2025
2 checks passed
@lantoli lantoli deleted the go_lint_v2 branch March 28, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EspenAlbert EspenAlbert EspenAlbert approved these changes

@oarbusi oarbusi oarbusi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lantoli @EspenAlbert @oarbusi