chore: bump aws-cdk-lib from 2.103.0 to 2.189.0 #437
Conversation
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/aws-cdk-lib-2.189.0
branch
from
ddf8f12 to
97980cb
Compare
|
This PR has gone 30 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 30 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy! |
|
@dependabot recreate |
Bumps [aws-cdk-lib](https://github.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib) from 2.103.0 to 2.189.0. - [Release notes](https://github.com/aws/aws-cdk/releases) - [Changelog](https://github.com/aws/aws-cdk/blob/main/CHANGELOG.v2.alpha.md) - [Commits](https://github.com/aws/aws-cdk/commits/v2.189.0/packages/aws-cdk-lib) --- updated-dependencies: - dependency-name: aws-cdk-lib dependency-version: 2.189.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/aws-cdk-lib-2.189.0
branch
from
c05c28a to
8b98580
Compare
lantoli
force-pushed
the
dependabot/npm_and_yarn/aws-cdk-lib-2.189.0
branch
from
e2fa290 to
0268e31
Compare
|
aws-cdk-lib udpates need a change in file |
|
updating to 2.200.1, as it's currently the latest version for aws-cdk-lib |
| Check whether the given object is a CfnResource. | ||
|
|
||
| ###### `construct`<sup>Required</sup> <a name="construct" id="awscdk-resources-mongodbatlas.CfnCloudBackUpRestoreJobs.isCfnResource.parameter.construct"></a> | ||
| ###### `x`<sup>Required</sup> <a name="x" id="awscdk-resources-mongodbatlas.CfnCloudBackUpRestoreJobs.isCfnResource.parameter.x"></a> |
There was a problem hiding this comment.
This change doesn't look intentional
There was a problem hiding this comment.
you're right, it also happens in 2.189.0, it's not related to 2.200.1, don't know if they've changed some behavior in doc generation. I also tried to update jsii-docgen to 10.7.4 but still get this file.
do you think this is a concern? not sure how useful this big file is
There was a problem hiding this comment.
after some investigation, I found the root cause: jsii-docgen processes inherited static methods from AWS CDK's base classes with minified parameter names. They must be doing this for the newest versions. When our classes extend CfnResource, they inherit methods like isCfnResource that were compiled with minified parameters (e.g., x instead of construct), e.g related issue
While the parameter name appears as x in the documentation, the functionality is still correct - it accepts the same construct parameter as expected. The documentation is technically accurate, just using a more generic parameter name rather than the specific construct type.
Given that this is a cosmetic issue in the generated documentation and doesn't affect the actual API functionality, I think it's better to keep the PR as it is.
One possible solution would be to post-process the documentation to modify it but this is complicated and error-prone so I don't think it's worth it.
@EspenAlbert please confirm if you agree to go ahead and merge this PR.
There was a problem hiding this comment.
Agree. Thank you for the investigation and fixing this 🙏
Bumps aws-cdk-lib from 2.103.0 to 2.189.0. EDIT: updated to 2.200.1.
Release notes
Sourced from aws-cdk-lib's releases.
... (truncated)
Changelog
Sourced from aws-cdk-lib's changelog.
... (truncated)
Commits
dcd077fchore: update analytics metadata blueprintsb997bf1chore(release): 2.189.0eec900efeat(apigatewayv2): dualstack HTTP and WebSocket API (#34054)9cb2602feat: update L1 CloudFormation resource definitions (#34064)2d901f4fix(codepipeline): replace account root principal with pipeline role in trust...3da0c4dfeat(bedrock): support Amazon Nova Reel 1.1 (#34070)b1e8879docs(pipelines): add link to developer guide on how to use docker drop-in rep...1b98a41docs(batch): add note on update fatgate compute environment (#34022)ef2d799docs(codepipeline-actions): fix permission's link for ECRBuildAndPublish (#34...994e952feat(pipelines): addV2pipeline type support in L3 construct (#34005)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.