Skip to content

Conversation

@EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented May 2, 2025

Proposed changes

Example artifact:

dist
├── changelog.md
├── dotnet
│   ├── MongoDB.AWSCDKResourcesMongoDBAtlas.3.12.0.nupkg
│   └── MongoDB.AWSCDKResourcesMongoDBAtlas.3.12.0.snupkg
├── go
│   └── awscdkresourcesmongodbatlas # full repo
├── java
│   └── org # /mongodb/awscdk-resources-mongodbatlas/3.12.0/awscdk-resources-mongodbatlas-3.12.0.jar
├── js
│   └── [email protected]
├── python
│   ├── awscdk_resources_mongodbatlas-3.12.0-py3-none-any.whl
│   └── awscdk_resources_mongodbatlas-3.12.0.tar.gz
├── releasetag.txt
└── version.txt

Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-316980

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert changed the title chore: Refactors release job to do all builds in step 1 and only download and publish in subsequent steps chore: Fix release job by doing all builds in step 1 and only download and publish in subsequent steps May 2, 2025
@EspenAlbert EspenAlbert marked this pull request as ready for review May 20, 2025 17:54
@EspenAlbert EspenAlbert requested a review from a team as a code owner May 20, 2025 17:54
- name: Create java artifact
run: cd .repo && npx projen compile && npx projen package:java
- name: Collect java Artifact
run: mv .repo/dist/java dist/java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we do some move files/directories, have you been able to check that this change works and releases are done correctly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks for following this up

Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EspenAlbert EspenAlbert merged commit 783bf01 into main May 21, 2025
7 of 8 checks passed
@EspenAlbert EspenAlbert deleted the release-one-step-build branch May 21, 2025 09:14
@EspenAlbert
Copy link
Collaborator Author

*Bypassed rule of changes to l1, as the same job is failing in main and is more cleanly done in a separate PR.
Failing main: https://github.com/mongodb/awscdk-resources-mongodbatlas/actions/runs/15158047661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants