-
Notifications
You must be signed in to change notification settings - Fork 21
chore: Fix release job by doing all builds in step 1 and only download and publish in subsequent steps #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…oad and publish in subsequent steps
| - name: Create java artifact | ||
| run: cd .repo && npx projen compile && npx projen package:java | ||
| - name: Collect java Artifact | ||
| run: mv .repo/dist/java dist/java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we do some move files/directories, have you been able to check that this change works and releases are done correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
lantoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks for following this up
oarbusi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
*Bypassed rule of changes to l1, as the same job is failing in main and is more cleanly done in a separate PR. |
Proposed changes
Example artifact:
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-316980
Type of change:
expected)
Required Checklist:
make fmtand formatted my codeFurther comments