chore: Sign PyPi artifact #455
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -155,11 +155,26 @@ jobs: | |
| - name: Restore build artifact permissions | ||
| run: cd dist && setfacl --restore=permissions-backup.acl | ||
| continue-on-error: true | ||
| - name: Import GPG key | ||
| uses: crazy-max/ghaction-import-gpg@e89d40939c28e39f97cf32126055eeae86ba74ec | ||
| with: | ||
| gpg_private_key: ${{ secrets.APIX_BOT_GPG_PRIVATE_KEY }} | ||
| passphrase: ${{ secrets.APIX_BOT_GPG_PASSPHRASE }} | ||
| - name: GPG sign PyPI distributions | ||
| run: | | ||
| for file in dist/awscdk_resources_mongodbatlas-*.whl dist/awscdk_resources_mongodbatlas-*.tar.gz; do | ||
oarbusi marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| if [ -f "$file" ]; then | ||
| gpg --batch --yes --pinentry-mode loopback --passphrase "$APIX_BOT_GPG_PASSPHRASE" --detach-sign -a "$file" | ||
| fi | ||
| done | ||
| env: | ||
| APIX_BOT_GPG_PASSPHRASE: ${{ secrets.APIX_BOT_GPG_PASSPHRASE }} | ||
|
|
||
| - name: Upload to PyPI | ||
|
There was a problem hiding this comment. [nitpick] Consider using Twine's built-in --sign flag to both sign and upload artifacts in one command (e.g., |
||
| env: | ||
| TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }} | ||
| TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }} | ||
| run: twine upload dist/* | ||
|
Collaborator
Author
There was a problem hiding this comment. Not able to test if we don't want to release 😆 , but I tried to keep changes to a minimum (do only what publib was doing)
Member
There was a problem hiding this comment. i understand, but just to make aware that we might have some issues in the next CDK release
Collaborator
Author
There was a problem hiding this comment. Agreed, we'll have to be careful on the next release |
||
| - name: Extract Version | ||
| id: extract-version | ||
| if: ${{ failure() }} | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you been able to test it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command I have tested, yes