Skip to content

Conversation

@oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Jun 26, 2025

Proposed changes

Add MAVEN_SERVER_ID for maven publishing

Link to any related issue(s): CLOUDP-323824

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi marked this pull request as ready for review June 26, 2025 12:42
Copilot AI review requested due to automatic review settings June 26, 2025 12:42
@oarbusi oarbusi requested a review from a team as a code owner June 26, 2025 12:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the MAVEN_SERVER_ID variable to the release workflow to support maven publishing.

  • Adds a new environment variable MAVEN_SERVER_ID to the release job.
  • Adjusts the workflow configuration to include this new variable.
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:124

  • The new environment variable MAVEN_SERVER_ID is sourced from vars while similar credentials are sourced from secrets. Please verify if this discrepancy is intentional or if it should be consistently sourced from secrets.
          MAVEN_SERVER_ID: ${{ vars.MAVEN_SERVER_ID }}

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oarbusi oarbusi merged commit 7e207ec into main Jun 26, 2025
14 checks passed
@oarbusi oarbusi deleted the CLOUDP-323824 branch June 26, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants