-
Notifications
You must be signed in to change notification settings - Fork 21
feat: Create CfnFlexCluster #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR creates a new CfnFlexCluster resource for MongoDB Atlas Flex clusters, which are flexible, scalable, and cost-optimized clusters for low-traffic applications with variable workloads.
Key changes:
- Generates CloudFormation resource bindings for
MongoDB::Atlas::FlexCluster - Adds comprehensive type definitions for flex cluster configuration
- Provides example implementation and integration test
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/l1-resources/flex-cluster/index.ts | Core flex cluster resource with TypeScript interfaces and CloudFormation bindings |
| src/l1-resources/flex-cluster/integ.default.ts | Integration test demonstrating basic flex cluster creation |
| src/l1-resources/flex-cluster/README.md | Documentation with usage examples and API references |
| src/index.ts | Main export file updated to include flex cluster types with conflict resolution |
| examples/l1-resources/flex-cluster.ts | Complete example showing project and flex cluster creation |
| API.md | Auto-generated API documentation for the new flex cluster resource |
| .projenrc.js | Build configuration updated with additional ignore patterns |
| .npmignore | Package ignore list updated to exclude development files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -0,0 +1,76 @@ | |||
| # flex-cluster | |||
|
|
|||
| The official [MongoDB Atlas](https://www.mongodb.com/) AWS CDK resource for Node.js. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n00b question, why do we mention Node.js here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly to doc in the other resources, they can also be used in Java, C#, Go, Python, this directoy has the Node resource definition
|
|
||
| The flex cluster resource provides access to your flex cluster configurations. The resource lets you create, edit and delete flex clusters. The resource requires your Project ID. | ||
|
|
||
| MongoDB Atlas Flex clusters provide a flexible, scalable, and cost-optimized solution for low-traffic applications and variable workloads. Flex clusters automatically scale compute and storage resources based on demand, offering a pay-as-you-go model. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this copy / pasted from somewhere? Can you add a link to the official MongoDB ATlas docs? https://www.mongodb.com/docs/atlas/create-database-deployment/#flex-clusters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to use the link instead: 197861a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, this is one of the files that the docs team will update
Proposed changes
Create CfnFlexCluster. Generate
index.tsfile from the corresponding CloudFormation resource. Add the other supporting files.Jira ticket: CLOUDP-342590
Link to any related issue(s):
Type of change:
expected)
Required Checklist:
make fmtand formatted my codeFurther comments