Skip to content

Conversation

@AgustinBettati
Copy link
Member

@AgustinBettati AgustinBettati commented Sep 9, 2025

Proposed changes

Cherry-picking changes from #485

Correctly propagates optional profile property from L3 to L1 constructs. Same pattern is seen in our other L3 resources (atlas-basic, atlas-basic-serverless-private-endpoint).

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

passed necessary profile option to the respective L1 resources
@AgustinBettati AgustinBettati marked this pull request as ready for review September 9, 2025 08:37
Copilot AI review requested due to automatic review settings September 9, 2025 08:37
@AgustinBettati AgustinBettati requested a review from a team as a code owner September 9, 2025 08:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the optional profile property was not being propagated from L3 to L1 constructs in the atlas-basic-private-endpoint resource, ensuring consistency with other L3 resources in the codebase.

  • Adds missing profile property propagation to CfnPrivateEndpointService constructor
  • Adds missing profile property propagation to CfnPrivateEndpoint constructor

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AgustinBettati AgustinBettati merged commit a87d33a into main Sep 9, 2025
16 checks passed
@AgustinBettati AgustinBettati deleted the fixing-l3-atlas-basic-private-endpoint branch September 9, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants