Skip to content

Conversation

@xargom
Copy link
Collaborator

@xargom xargom commented Sep 10, 2025

Proposed changes

Jira ticket: DOCSP-53434

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Added a link referring to the new flex clusters in the readme file.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@xargom xargom requested a review from a team as a code owner September 10, 2025 13:45
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we have to wait to merge this until flex cluster is fully released in CFN, right @lantoli ?

Copy link
Collaborator

@antellezr-mdb antellezr-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor observation.

@lantoli
Copy link
Member

lantoli commented Sep 11, 2025

LGTM, we have to wait to merge this until flex cluster is fully released in CFN, right @lantoli ?

@oarbusi already done

Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once comments are addressed

Copy link
Collaborator Author

@xargom xargom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments addressed

Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge once the last comments are addressed

@xargom xargom merged commit dc183e6 into main Sep 12, 2025
14 checks passed
@xargom xargom deleted the DOCSP-53434 branch September 12, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants