-
Notifications
You must be signed in to change notification settings - Fork 21
doc: DOCSP-53434 -- Update doc for CfnCluster CDK resource #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
oarbusi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we have to wait to merge this until flex cluster is fully released in CFN, right @lantoli ?
antellezr-mdb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a minor observation.
lantoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once comments are addressed
Co-authored-by: antellezr-mdb <[email protected]>
xargom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments addressed
lantoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge once the last comments are addressed
Co-authored-by: Leo Antoli <[email protected]>
Proposed changes
Jira ticket: DOCSP-53434
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Added a link referring to the new flex clusters in the readme file.
Link to any related issue(s):
Type of change:
expected)
Required Checklist:
make fmtand formatted my codeFurther comments