-
Notifications
You must be signed in to change notification settings - Fork 21
chore: Fix release #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix release #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issues in the GitHub Actions release workflow that were preventing successful publishing to various package repositories. The changes focus on updating npm publishing configuration, fixing PyPI upload commands, and ensuring proper repository checkout for compliance steps.
- Updated npm publishing to use
publib-npmtool with proper environment variable configuration - Fixed PyPI upload to install twine and specify correct file paths
- Added missing repository checkout step for compliance generation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
EspenAlbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY!
marcosuma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lantoli ! Any idea on how we got into the need of these code changes to fix it?
@marcosuma I think the main issue here is that we made (significant) changes in the release process but didn't test it. It was hard to test, a fork couldn't be used because a real release would be needed. a possible solution for next time is to do a real release, even if there are not business changes, so the release process is executed. |
Proposed changes
Code changes to fix release got from this PR 504 when trying to do the release and fixing different packages.
Type of change:
expected)
Required Checklist:
make fmtand formatted my codeFurther comments