Skip to content

Conversation

@lantoli
Copy link
Member

@lantoli lantoli commented Sep 15, 2025

Proposed changes

Code changes to fix release got from this PR 504 when trying to do the release and fixing different packages.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli marked this pull request as ready for review September 15, 2025 19:31
@lantoli lantoli requested a review from a team as a code owner September 15, 2025 19:31
Copilot AI review requested due to automatic review settings September 15, 2025 19:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues in the GitHub Actions release workflow that were preventing successful publishing to various package repositories. The changes focus on updating npm publishing configuration, fixing PyPI upload commands, and ensuring proper repository checkout for compliance steps.

  • Updated npm publishing to use publib-npm tool with proper environment variable configuration
  • Fixed PyPI upload to install twine and specify correct file paths
  • Added missing repository checkout step for compliance generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lantoli lantoli mentioned this pull request Sep 15, 2025
10 tasks
Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

Copy link
Collaborator

@marcosuma marcosuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lantoli ! Any idea on how we got into the need of these code changes to fix it?

@lantoli
Copy link
Member Author

lantoli commented Sep 16, 2025

Thank you @lantoli ! Any idea on how we got into the need of these code changes to fix it?

@marcosuma I think the main issue here is that we made (significant) changes in the release process but didn't test it. It was hard to test, a fork couldn't be used because a real release would be needed.

a possible solution for next time is to do a real release, even if there are not business changes, so the release process is executed.

@lantoli lantoli merged commit 0806b2e into main Sep 16, 2025
14 checks passed
@lantoli lantoli deleted the fix_release branch September 16, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants