Skip to content

chore: Remove data-lake and data-lake-pipeline L1 resources #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2025
Merged

chore: Remove data-lake and data-lake-pipeline L1 resources #520

merged 2 commits into from
Nov 3, 2025

Conversation

@lantoli
Copy link
Member

@lantoli lantoli commented Nov 3, 2025 •
edited
Loading

Remove data-lake and data-lake-pipeline L1 resources. They've already been removed from CFN.

Jira ticket: CLOUDP-356362

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli marked this pull request as ready for review November 3, 2025 11:04
@lantoli lantoli requested a review from a team as a code owner November 3, 2025 11:04
Copilot AI review requested due to automatic review settings November 3, 2025 11:04
Copilot AI reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated data-lake and data-lake-pipeline L1 resources from the codebase. The removal is warranted as Data Lake was deprecated in September 2024 and users should migrate to alternative solutions.

Key changes:

  • Removed all data-lake and data-lake-pipeline L1 resource implementations
  • Removed associated test files and documentation
  • Updated main index exports to exclude removed resources

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/l1-resources/datalakes/index.ts Removed complete data lakes L1 resource implementation including interfaces, enums, and CloudFormation resource class
src/l1-resources/data-lake-pipeline/index.ts Removed complete data lake pipeline L1 resource implementation including interfaces, enums, and CloudFormation resource class
src/index.ts Removed exports for both CfnDataLakes and CfnDataLakePipeline resources and their associated types
src/README.md Removed datalakes entry from L1 resources table
test/l1-resources/data-lake-pipeline/index.test.ts Removed test suite for data lake pipeline resource
examples/l1-resources/datalake.ts Removed example implementation for data lakes
examples/l1-resources/data-lake-pipeline.ts Removed example implementation for data lake pipeline
src/l1-resources/datalakes/README.md Removed documentation for data lakes resource
src/l1-resources/data-lake-pipeline/README.md Removed documentation for data lake pipeline resource
test/l1-resources/datalakes/README.md Removed test documentation for data lakes
test/l1-resources/data-lake-pipeline/README.md Removed test documentation for data lake pipeline
src/l1-resources/data-lake-pipeline/integ.default.ts Removed integration test for data lake pipeline

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

marcosuma
marcosuma approved these changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@marcosuma marcosuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't open the API.md file, so just making sure that it's correct that so many changes are happening there?

@lantoli
Copy link
Member Author

lantoli commented Nov 3, 2025

@marcosuma API.md is generated automatically, it has many changes because 2 resources are deleted, also check-l1-updated GHA checks this file is correct

@lantoli lantoli merged commit 9ee90b8 into main Nov 3, 2025
22 checks passed
@lantoli lantoli deleted the CLOUDP-356362_l1-update branch November 3, 2025 11:36
lantoli added a commit that referenced this pull request Nov 3, 2025
@lantoli
Merge branch 'main' into dependabot/github_actions/actions/upload-art…
d2a1f15 
…ifact-5

* main:
  chore: Remove data-lake and data-lake-pipeline L1 resources (#520)
  chore: bump actions/download-artifact from 5.0.0 to 6.0.0 (#519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@marcosuma marcosuma marcosuma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lantoli @marcosuma