-
Notifications
You must be signed in to change notification settings - Fork 21
chore: Use Trusted Publishing in NPM publish #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the project from Yarn to NPM and implements Trusted Publishing for the NPM release workflow. Key changes include updating Node.js to 24.x (latest LTS), Java to 21.x, and Go to 1.25.x to meet Trusted Publishing requirements. The changes also simplify GitHub Actions workflows by standardizing checkout action usage and removing automatic issue creation on release failures.
- Removed Yarn in favor of NPM with Trusted Publishing support
- Updated runtime versions: Node.js 24.x, Java 21.x, Go 1.25.x
- Simplified GitHub Actions workflows and removed automatic issue creation on release failures
Reviewed Changes
Copilot reviewed 13 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .tool-versions | Updated Node.js to 24.11.0 and removed Yarn |
| package.json | Updated projen dependency version |
| .projenrc.js | Configured NPM as package manager and updated exclude patterns |
| .projen/tasks.json | Replaced Yarn commands with NPM equivalents |
| .npmrc | Added legacy-peer-deps configuration |
| .npmignore | Updated log file patterns from Yarn to NPM |
| .github/workflows/release.yml | Implemented Trusted Publishing, updated runtime versions, removed automatic issue creation |
| .github/workflows/package.yml | Updated Node.js version and install commands across all package jobs |
| .github/workflows/upgrade-main.yml | Updated Node.js version and install commands |
| .github/workflows/dependency-review.yml | Simplified checkout action usage |
| .github/workflows/code-health.yml | Updated Node.js version, install commands, and self-mutation detection logic |
| .gitattributes | Updated lock file tracking from yarn.lock to package-lock.json |
| API.md | Generated documentation updates marking isConstruct methods as deprecated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| node-version: 18.x | ||
| node-version: 24.x | ||
| - name: Install dependencies | ||
| run: yarn install --check-files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, why 2 package managers when we can have just 1 :-)
| with: | ||
| name: .repo.patch | ||
| path: .repo.patch | ||
| include-hidden-files: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were hidden files not needed before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's a new param, it took all files before. anyway this is a nit, it's to have a git patch when there are differences, in the normal use case where everything is ok, this is not needed.
Use Trusted Publishing in NPM publish, more info here. Trusted Publishing in NPM can't be tested until a real publish is done.
Jira ticket: CLOUDP-352053
Type of change:
expected)
Required Checklist:
make fmtand formatted my codeFurther comments