Skip to content

Conversation

@lantoli
Copy link
Member

@lantoli lantoli commented Nov 6, 2025

Generate L1 resources without datalake references.

Generate L1 resources after this CFN change: mongodb/mongodbatlas-cloudformation-resources#1474

Proposed changes

Jira ticket: CLOUDP-344019

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • I have tested the CDK constructor in a CFN stack. See TESTING.md
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli changed the title chore: generate l1 resources without datalake references chore: Generate L1 resources without datalake references Nov 6, 2025
@lantoli lantoli marked this pull request as ready for review November 6, 2025 09:07
@lantoli lantoli requested a review from a team as a code owner November 6, 2025 09:07
Copilot AI review requested due to automatic review settings November 6, 2025 09:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes references to the deprecated PrivateEndpointADL L1 resource and updates terminology throughout the codebase from "Atlas Data Lake" to "Atlas Data Federation" to align with MongoDB's current naming conventions.

  • Removes the CfnPrivateEndpointAdl L1 resource class and associated files
  • Updates documentation and comments to use "Atlas Data Federation" instead of "Atlas Data Lake"
  • Fixes variable naming inconsistencies in example code

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/l1-resources/private-endpoint-adl/index.test.ts Removes test file for deprecated PrivateEndpointADL resource
test/l1-resources/private-endpoint-adl/README.md Removes documentation for deprecated PrivateEndpointADL resource
src/l3-resources/common/props.ts Updates terminology from "Data Lakes" to "Data Federation" in DatabaseUserProps comments
src/l1-resources/privatelink-endpoint-service-data-federation-online-archive/index.ts Updates terminology from "Data Lake" to "Data Federation" in comments
src/l1-resources/private-endpoint-regional-mode/README.md Fixes variable naming in example code
src/l1-resources/private-endpoint-adl/index.ts Removes deprecated PrivateEndpointADL resource implementation
src/l1-resources/private-endpoint-adl/README.md Removes documentation for deprecated PrivateEndpointADL resource
src/l1-resources/federated-database-instance/index.ts Updates terminology from "data lake" to "Atlas Data Federation" throughout
src/l1-resources/database-user/index.ts Updates terminology from "Data Lakes" to "Data Federation" in comments
src/index.ts Removes export of deprecated CfnPrivateEndpointAdl
src/README.md Removes private-endpoint-adl entry from L1 resources table
examples/l1-resources/private-endpoint-regional-mode.ts Fixes variable naming from myPrivateEndpointAdl to myPrivateEndpoint
examples/l1-resources/private-endpoint-adl.ts Removes example file for deprecated PrivateEndpointADL resource
API.md Removes API documentation for deprecated CfnPrivateEndpointAdl and updates terminology throughout

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantoli lantoli merged commit d9f65c2 into main Nov 6, 2025
15 checks passed
@lantoli lantoli deleted the CLOUDP-344019_update_l1 branch November 6, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants