Skip to content

Final (?) tweaks to release workflow #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamis merged 2 commits into from
Jun 27, 2025
Merged

Final (?) tweaks to release workflow #362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd95482
use push & workflow_dispatch triggers
jamis Jun 19, 2025
cd34cad
push trigger expects a branches key, not just a list
jamis Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,23 @@ run-name: "BSON Release for ${{ github.ref }}"

on:
# for auto-deploy when merging a release-candidate PR
pull_request:
types: [ closed ]
push:
branches:
- 'master'
- '*-stable'

# for manual release trigger: "/release" in a comment on a merged
# release-candidate PR (useful if the auto-deploy fails)
issue_comment:
types: [ created ]
# for manual release
workflow_dispatch:
inputs:
pr:
description: "The number of the merged release candidate PR"
required: true

env:
SILK_ASSET_GROUP: bson-ruby
GEM_NAME: bson
PRODUCT_NAME: BSON for Ruby
PRODUCT_ID: mongodb-ruby-driver

permissions:
# required for all workflows
Expand Down Expand Up @@ -58,7 +65,7 @@ jobs:
app_id: ${{ vars.APP_ID }}
app_private_key: ${{ secrets.APP_PRIVATE_KEY }}
artifact: ${{ matrix.ruby }}
gem_name: bson
gem_name: ${{ env.GEM_NAME }}
ruby_version: ${{ matrix.ruby }}
ref: ${{ needs.check.outputs.ref }}

Expand All @@ -77,9 +84,9 @@ jobs:
aws_region_name: ${{ vars.AWS_REGION_NAME }}
aws_secret_id: ${{ secrets.AWS_SECRET_ID }}
dry_run: false
gem_name: bson
product_name: BSON for Ruby
product_id: mongodb-ruby-driver
gem_name: ${{ env.GEM_NAME }}
product_name: ${{ env.PRODUCT_NAME }}
product_id: ${{ env.PRODUCT_ID }}
release_message: ${{ needs.check.outputs.message }}
silk_asset_group: ${{ env.SILK_ASSET_GROUP }}
ref: ${{ needs.check.outputs.ref }}