separate query log message args with a comma #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output should be something like:
collection.udate_many({'$expr': {...}}, {'$set': {...}})
Jibola
approved these changes
Aug 20, 2024
Comment on lines
42
to
+44
| def log(self, op, duration, args, kwargs=None): | ||
| # If kwargs are used by any operations in the future, they must be | ||
| # added to this logging. |
There was a problem hiding this comment.
What's the likelihood that any operations will be added here in the future?
There was a problem hiding this comment.
I'm not sure. You can look at the kwargs for update_many(), for example, and see if you think developers will need some way to specify any of them for QuerySet operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, remove obsolete bits of query logging.