add expression support to QuerySet.update() #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
reviewed
Aug 22, 2024
| @@ -342,12 +293,6 @@ def django_test_expected_failures(self): | |||
| "delete_regress.tests.Ticket19102Tests.test_ticket_19102_select_related", | |||
| "one_to_one.tests.OneToOneTests.test_o2o_primary_key_delete", | |||
| }, | |||
| "Cannot use QuerySet.update() when querying across multiple collections on MongoDB.": { | |||
There was a problem hiding this comment.
I believe we should keep this error message. Raising "Using a QuerySet in annotate() is not supported on MongoDB" isn't helpful for the user since this isn't what they're doing but rather what Django is doing behind the scenes (kind of... really this error message needs to be changed since Query is used in more than just annotate()).
There was a problem hiding this comment.
Ok. yes, But the other test are going to be recategorized also?
| spec.setdefault("$set", {})[field.column] = value | ||
| return self.execute_update(spec) | ||
|
|
||
| @wrap_database_errors |
There was a problem hiding this comment.
We lost this decorator.
There was a problem hiding this comment.
Who needs the safe net?! my bad. 😬 deleted by mistake.
WaVEV
force-pushed
the
support-update-with-expression
branch
from
39e15fd to
a8ff458
Compare
timgraham
changed the title
WaVEV
force-pushed
the
support-update-with-expression
branch
from
6abb648 to
c6d4736
Compare
timgraham
force-pushed
the
support-update-with-expression
branch
from
c6d4736 to
2d96786
Compare
timgraham
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102