implement SchemaEditor.add/remove_field() #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
schema-fields
branch
from
6d640d6 to
78ddcc8
Compare
WaVEV
reviewed
Sep 7, 2024
django_mongodb/schema.py
Outdated
| if field.many_to_many and field.remote_field.through._meta.auto_created: | ||
| self.create_model(field.remote_field.through) | ||
| return | ||
| default = self.effective_default(field) |
There was a problem hiding this comment.
This variable is only used in the line 18, could we move this line or erase it? or the method must be called?
WaVEV
approved these changes
Sep 7, 2024
timgraham
force-pushed
the
schema-fields
branch
from
78ddcc8 to
cf2e29a
Compare
timgraham
force-pushed
the
schema-fields
branch
from
cf2e29a to
4e16422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #115