add support for unique constraints #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
unique-constraints
branch
3 times, most recently
from
88a8960 to
7679ae0
Compare
timgraham
force-pushed
the
unique-constraints
branch
2 times, most recently
from
ad9e91e to
1fa1624
Compare
timgraham
force-pushed
the
unique-constraints
branch
4 times, most recently
from
9d58631 to
28c3218
Compare
timgraham
force-pushed
the
unique-constraints
branch
from
28c3218 to
85d32a5
Compare
WaVEV
approved these changes
Oct 11, 2024
Jibola
approved these changes
Oct 21, 2024
Comment on lines
+50
to
+51
| for constraint in model._meta.constraints: | ||
| self.add_constraint(model, constraint) |
There was a problem hiding this comment.
Does this addition also mean that this PR will support BaseConstraints?
There was a problem hiding this comment.
BaseConstraint is just a common base class. It isn't something that's used on a model's Meta.constraints.
And also creating uniques in create_model() and add_field(), and removing them in remove_field().
timgraham
force-pushed
the
unique-constraints
branch
from
85d32a5 to
d3a106c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #104