make ObjectIdAutoField.to_python() accept integers as strings #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgraham
force-pushed
the
autofield-to-python
branch
from
b524c2f to
8bb17ee
Compare
|
Hrm, why should this silently accept an int conversion on the autofield? I understand that uncoerced data comes through the form construction, but wouldn't this be breaking assumptions on ObjectId types? |
|
This is a continuation of #105 (comment). |
|
Ahhhh, thanks for the reminder. Now that it's called "ObjectIdAutoField" rather than "MongoAutoField" I imagine this could lead to some confusion. Nonetheless, let's add the change in, but could you add a comment above including this ticket? https://jira.mongodb.org/browse/INTPYTHON-393 I don't think it's an issue now, nor is this a bad solution. I would want to revisit the semantics of this at a later date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are at least two places in Django where
Field.to_python()processes uncoerced form data,BaseModelFormSet._construct_form()andModelAdmin.get_object().