implement ObjectIdAutoField.deconstruct() #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove "auto" from path and omit default db_column from kwargs.
Jibola
reviewed
Oct 29, 2024
Comment on lines
+22
to
+23
| if path.startswith("django_mongodb.fields.auto"): | ||
| path = path.replace("django_mongodb.fields.auto", "django_mongodb.fields") |
There was a problem hiding this comment.
Why do we do this? Just for consistency in path imports or is there a technical reason, too?
There was a problem hiding this comment.
Similar to https://github.com/django/django/blob/163e72ebbaa84804877f3d1ae212575e479b533b/django/db/models/fields/__init__.py#L646-L657, the fact that our fields are implemented in submodules of django_mongodb.fields is an implementation detail that's fine to hide from end users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.