-
Notifications
You must be signed in to change notification settings - Fork 26
INTPYTHON-348 add support for QuerySet.raw_aggregate() #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
from django.db.models.manager import BaseManager | ||
|
||
from .queryset import MongoQuerySet | ||
|
||
|
||
class MongoManager(BaseManager.from_queryset(MongoQuerySet)): | ||
pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
from itertools import chain | ||
|
||
from django.core.exceptions import FieldDoesNotExist | ||
from django.db import connections | ||
from django.db.models import QuerySet | ||
from django.db.models.query import RawModelIterable as BaseRawModelIterable | ||
from django.db.models.query import RawQuerySet as BaseRawQuerySet | ||
from django.db.models.sql.query import RawQuery as BaseRawQuery | ||
|
||
|
||
class MongoQuerySet(QuerySet): | ||
def raw_aggregate(self, pipeline, using=None): | ||
return RawQuerySet(pipeline, model=self.model, using=using) | ||
|
||
|
||
class RawQuerySet(BaseRawQuerySet): | ||
def __init__(self, pipeline, model=None, using=None): | ||
super().__init__(pipeline, model=model, using=using) | ||
self.query = RawQuery(pipeline, using=self.db, model=self.model) | ||
# Override the superclass's columns property which relies on PEP 249's | ||
# cursor.description. Instead, RawModelIterable will set the columns | ||
# based on the keys in the first result. | ||
self.columns = None | ||
|
||
def iterator(self): | ||
yield from RawModelIterable(self) | ||
|
||
|
||
class RawQuery(BaseRawQuery): | ||
def __init__(self, pipeline, using, model): | ||
self.pipeline = pipeline | ||
super().__init__(sql=None, using=using) | ||
self.model = model | ||
|
||
def _execute_query(self): | ||
connection = connections[self.using] | ||
collection = connection.get_collection(self.model._meta.db_table) | ||
self.cursor = collection.aggregate(self.pipeline) | ||
|
||
def __str__(self): | ||
return str(self.pipeline) | ||
|
||
|
||
class RawModelIterable(BaseRawModelIterable): | ||
def __iter__(self): | ||
""" | ||
This is copied from the superclass except for the part that sets | ||
self.queryset.columns from the first result. | ||
""" | ||
db = self.queryset.db | ||
query = self.queryset.query | ||
connection = connections[db] | ||
compiler = connection.ops.compiler("SQLCompiler")(query, connection, db) | ||
query_iterator = iter(query) | ||
try: | ||
# Get the columns from the first result. | ||
try: | ||
first_result = next(query_iterator) | ||
except StopIteration: | ||
# No results. | ||
return | ||
self.queryset.columns = list(first_result.keys()) | ||
# Reset the iterator to include the first item. | ||
query_iterator = self._make_result(chain([first_result], query_iterator)) | ||
( | ||
model_init_names, | ||
model_init_pos, | ||
annotation_fields, | ||
) = self.queryset.resolve_model_init_order() | ||
model_cls = self.queryset.model | ||
if model_cls._meta.pk.attname not in model_init_names: | ||
raise FieldDoesNotExist("Raw query must include the primary key") | ||
fields = [self.queryset.model_fields.get(c) for c in self.queryset.columns] | ||
converters = compiler.get_converters( | ||
[f.get_col(f.model._meta.db_table) if f else None for f in fields] | ||
) | ||
if converters: | ||
query_iterator = compiler.apply_converters(query_iterator, converters) | ||
for values in query_iterator: | ||
# Associate fields to values | ||
model_init_values = [values[pos] for pos in model_init_pos] | ||
instance = model_cls.from_db(db, model_init_names, model_init_values) | ||
if annotation_fields: | ||
for column, pos in annotation_fields: | ||
setattr(instance, column, values[pos]) | ||
yield instance | ||
finally: | ||
query.cursor.close() | ||
|
||
def _make_result(self, query): | ||
""" | ||
Convert documents (dictionaries) to tuples as expected by the rest | ||
of __iter__(). | ||
""" | ||
for result in query: | ||
yield tuple(result.values()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
``QuerySet`` API reference | ||
========================== | ||
|
||
Some MongoDB-specific ``QuerySet`` methods are available by adding a custom | ||
:class:`~django.db.models.Manager`, ``MongoManager``, to your model:: | ||
|
||
from django.db import models | ||
|
||
from django_mongodb.managers import MongoManager | ||
|
||
|
||
class MyModel(models.Model): | ||
... | ||
|
||
objects = MongoManager() | ||
|
||
|
||
.. currentmodule:: django_mongodb.queryset.MongoQuerySet | ||
|
||
``raw_aggregate()`` | ||
------------------- | ||
|
||
.. method:: raw_aggregate(pipeline, using=None) | ||
|
||
Similar to :meth:`QuerySet.raw()<django.db.models.query.QuerySet.raw>`, but | ||
instead of a raw SQL query, this method accepts a pipeline that will be passed | ||
to :meth:`pymongo.collection.Collection.aggregate`. | ||
|
||
For example, you could write a custom match criteria:: | ||
|
||
Question.objects.raw_aggregate([{"$match": {"question_text": "What's up"}}]) | ||
|
||
The pipeline may also return additional fields that will be added as | ||
annotations on the models:: | ||
|
||
>>> questions = Question.objects.raw_aggregate([{ | ||
... "$project": { | ||
... "question_text": 1, | ||
... "pub_date": 1, | ||
... "year_published": {"$year": "$pub_date"} | ||
... } | ||
... }]) | ||
>>> for q in questions: | ||
... print(f"{q.question_text} was published in {q.year_published}.") | ||
... | ||
What's up? was published in 2024. | ||
|
||
Fields may also be left out: | ||
|
||
>>> Question.objects.raw_aggregate([{"$project": {"question_text": 1}}]) | ||
|
||
The ``Question`` objects returned by this query will be deferred model instances | ||
(see :meth:`~django.db.models.query.QuerySet.defer()`). This means that the | ||
fields that are omitted from the query will be loaded on demand. For example:: | ||
|
||
>>> for q in Question.objects.raw_aggregate([{"$project": {"question_text": 1}}]): | ||
>>> print( | ||
... q.question_text, # This will be retrieved by the original query. | ||
... q.pub_date, # This will be retrieved on demand. | ||
... ) | ||
... | ||
What's new 2023-09-03 12:00:00+00:00 | ||
What's up 2024-08-23 20:57:30+00:00 | ||
|
||
From outward appearances, this looks like the query has retrieved both the | ||
question text and published date. However, this example actually issued three | ||
queries. Only the question texts were retrieved by the ``raw_aggregate()`` | ||
query -- the published dates were both retrieved on demand when they were | ||
printed. |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
from django.db import models | ||
|
||
from django_mongodb.fields import ObjectIdAutoField | ||
from django_mongodb.managers import MongoManager | ||
|
||
|
||
class Author(models.Model): | ||
first_name = models.CharField(max_length=255) | ||
last_name = models.CharField(max_length=255) | ||
dob = models.DateField() | ||
|
||
objects = MongoManager() | ||
|
||
def __init__(self, *args, **kwargs): | ||
super().__init__(*args, **kwargs) | ||
# Protect against annotations being passed to __init__ -- | ||
# this'll make the test suite get angry if annotations aren't | ||
# treated differently than fields. | ||
for k in kwargs: | ||
assert k in [f.attname for f in self._meta.fields], ( | ||
"Author.__init__ got an unexpected parameter: %s" % k | ||
) | ||
Comment on lines
+14
to
+22
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this init needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is copied from Django's test suite. |
||
|
||
|
||
class Book(models.Model): | ||
title = models.CharField(max_length=255) | ||
author = models.ForeignKey(Author, models.CASCADE) | ||
paperback = models.BooleanField(default=False) | ||
opening_line = models.TextField() | ||
|
||
objects = MongoManager() | ||
|
||
|
||
class BookFkAsPk(models.Model): | ||
book = models.ForeignKey(Book, models.CASCADE, primary_key=True, db_column="not_the_default") | ||
|
||
objects = MongoManager() | ||
|
||
|
||
class Coffee(models.Model): | ||
brand = models.CharField(max_length=255, db_column="name") | ||
price = models.DecimalField(max_digits=10, decimal_places=2, default=0) | ||
|
||
objects = MongoManager() | ||
|
||
|
||
class MixedCaseIDColumn(models.Model): | ||
id = ObjectIdAutoField(primary_key=True, db_column="MiXeD_CaSe_Id") | ||
|
||
objects = MongoManager() | ||
|
||
|
||
class Reviewer(models.Model): | ||
reviewed = models.ManyToManyField(Book) | ||
|
||
objects = MongoManager() | ||
|
||
|
||
class FriendlyAuthor(Author): | ||
pass |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this would be the only thing that gets updated were we to create a
raw_find
version if I understand correctly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so. With some adjustments for the fact that
find()
has more arguments (at leastfilter
andprojection
).Incidentally, that raises the question as to whether
raw_aggregate()
should also accept arbitrary**kwargs
to pass toCollection.aggregate()
.