Skip to content

Conversation

blink1073
Copy link
Member

No description provided.

@blink1073 blink1073 requested a review from Jibola November 18, 2024 16:04
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jibola
Copy link
Contributor

Jibola commented Nov 19, 2024

Would we also need to set persist-credentials: false to the release-python.yml?

@blink1073
Copy link
Member Author

There aren't any checkouts in that file:

zizmor . && echo "hi"
🌈 completed release-python.yml
🌈 completed codeql.yml
🌈 completed zizmor.yml
🌈 completed test-python.yml
🌈 completed dist.yml
🌈 completed linters.yml
No findings to report. Good job!
hi

@blink1073 blink1073 merged commit b730288 into mongodb:main Nov 19, 2024
10 checks passed
@blink1073 blink1073 deleted the PYTHON-4969 branch November 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants