Skip to content

require settings.DATABASES['NAME'] #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/runtests.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"apps",
"async",
"auth_tests",
"backend_",
"backends",
"basic",
"bulk_create",
Expand Down
7 changes: 4 additions & 3 deletions django_mongodb/base.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import contextlib

from django.core.exceptions import ImproperlyConfigured
from django.db.backends.base.base import BaseDatabaseWrapper
from pymongo.collection import Collection
from pymongo.mongo_client import MongoClient
Expand Down Expand Up @@ -151,13 +152,13 @@ def __getattr__(self, attr):
raise AttributeError(attr)

def init_connection_state(self):
db_name = self.settings_dict["NAME"]
if db_name:
self.database = self.connection[db_name]
self.database = self.connection[self.settings_dict["NAME"]]
super().init_connection_state()

def get_connection_params(self):
settings_dict = self.settings_dict
if not settings_dict["NAME"]:
raise ImproperlyConfigured('settings.DATABASES is missing the "NAME" value.')
return {
"host": settings_dict["HOST"] or None,
"port": int(settings_dict["PORT"] or 27017),
Expand Down
Empty file added tests/backend_/__init__.py
Empty file.
14 changes: 14 additions & 0 deletions tests/backend_/test_base.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
from django.core.exceptions import ImproperlyConfigured
from django.db import connection
from django.test import SimpleTestCase

from django_mongodb.base import DatabaseWrapper


class DatabaseWrapperTests(SimpleTestCase):
def test_database_name_empty(self):
settings = connection.settings_dict.copy()
settings["NAME"] = ""
msg = 'settings.DATABASES is missing the "NAME" value.'
with self.assertRaisesMessage(ImproperlyConfigured, msg):
DatabaseWrapper(settings).get_connection_params()
Loading