Skip to content

remove unnecessary $literal wrapping in Value.as_mql() #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions django_mongodb/expressions.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,20 +203,26 @@ def when(self, compiler, connection):

def value(self, compiler, connection): # noqa: ARG001
value = self.value
if isinstance(value, int):
# Wrap numbers in $literal to prevent ambiguity when Value appears in
# $project.
return {"$literal": value}
if isinstance(value, Decimal):
value = Decimal128(value)
elif isinstance(value, datetime.date):
return Decimal128(value)
if isinstance(value, datetime.datetime):
return value
if isinstance(value, datetime.date):
# Turn dates into datetimes since BSON doesn't support dates.
value = datetime.datetime.combine(value, datetime.datetime.min.time())
elif isinstance(value, datetime.time):
return datetime.datetime.combine(value, datetime.datetime.min.time())
if isinstance(value, datetime.time):
# Turn times into datetimes since BSON doesn't support times.
value = datetime.datetime.combine(datetime.datetime.min.date(), value)
elif isinstance(value, datetime.timedelta):
return datetime.datetime.combine(datetime.datetime.min.date(), value)
if isinstance(value, datetime.timedelta):
# DurationField stores milliseconds rather than microseconds.
value /= datetime.timedelta(milliseconds=1)
elif isinstance(value, UUID):
value = value.hex
return {"$literal": value}
return value / datetime.timedelta(milliseconds=1)
if isinstance(value, UUID):
return value.hex
return value


def register_expressions():
Expand Down
Empty file added tests/expressions_/__init__.py
Empty file.
43 changes: 43 additions & 0 deletions tests/expressions_/test_value.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import datetime
import uuid
from decimal import Decimal

from bson import Decimal128
from django.db.models import Value
from django.test import SimpleTestCase


class ValueTests(SimpleTestCase):
def test_date(self):
self.assertEqual(
Value(datetime.date(2025, 1, 1)).as_mql(None, None),
datetime.datetime(2025, 1, 1),
)

def test_datetime(self):
self.assertEqual(
Value(datetime.datetime(2025, 1, 1, 9, 8, 7)).as_mql(None, None),
datetime.datetime(2025, 1, 1, 9, 8, 7),
)

def test_decimal(self):
self.assertEqual(Value(Decimal("1.0")).as_mql(None, None), Decimal128("1.0"))

def test_time(self):
self.assertEqual(
Value(datetime.time(9, 8, 7)).as_mql(None, None),
datetime.datetime(1, 1, 1, 9, 8, 7),
)

def test_timedelta(self):
self.assertEqual(Value(datetime.timedelta(3600)).as_mql(None, None), 311040000000.0)

def test_int(self):
self.assertEqual(Value(1).as_mql(None, None), {"$literal": 1})

def test_str(self):
self.assertEqual(Value("foo").as_mql(None, None), "foo")

def test_uuid(self):
value = uuid.UUID(int=1)
self.assertEqual(Value(value).as_mql(None, None), "00000000000000000000000000000001")
Loading