PYTHON-5047 Fix dry run logic in releases yet again #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibola
approved these changes
Jan 29, 2025
| DRY_RUN: ${{ github.event_name == 'workflow_dispatch' && inputs.dry_run || 'true' }} | ||
| # inputs will be empty on a scheduled run. so, we only set dry_run | ||
| # to 'false' when the input is set to 'false'. | ||
| DRY_RUN: ${{ ! contains(inputs.dry_run, 'false') }} |
There was a problem hiding this comment.
why does it have to be a contains?
Would an equality not work the same?
There was a problem hiding this comment.
Perhaps, but this variant has already been tested. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mongodb/motor#323 for details.