-
Notifications
You must be signed in to change notification settings - Fork 28
Add a database router so dumpdata can ignore embedded models #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
from django.apps import apps | ||
|
||
from django_mongodb_backend.models import EmbeddedModel | ||
|
||
|
||
class MongoRouter: | ||
def allow_migrate(self, db, app_label, model_name=None, **hints): | ||
""" | ||
EmbeddedModels don't have their own collection and must be ignored by | ||
dumpdata. | ||
""" | ||
if not model_name: | ||
return None | ||
try: | ||
model = apps.get_model(app_label, model_name) | ||
except LookupError: | ||
return None | ||
return False if issubclass(model, EmbeddedModel) else None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,11 @@ | ||
from django.db import models | ||
|
||
from django_mongodb_backend.models import EmbeddedModel | ||
|
||
|
||
class Embed(EmbeddedModel): | ||
pass | ||
|
||
|
||
class PlainModel(models.Model): | ||
pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
from django.test import SimpleTestCase | ||
|
||
from django_mongodb_backend.routers import MongoRouter | ||
|
||
|
||
class TestRouter(SimpleTestCase): | ||
def setUp(self): | ||
self.router = MongoRouter() | ||
|
||
def test_no_model(self): | ||
self.assertIsNone(self.router.allow_migrate("db", "models_")) | ||
|
||
def test_regular_model(self): | ||
self.assertIsNone(self.router.allow_migrate("db", "models_", "plainmodel")) | ||
|
||
def test_nonexistent_model(self): | ||
self.assertIsNone(self.router.allow_migrate("db", "models_", "nonexistentmodel")) | ||
|
||
def test_embedded_model(self): | ||
self.assertIs(self.router.allow_migrate("db", "models_", "embed"), False) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aclark4life
Can you make a change to the django-mongodb-project template to have this be a default setting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mongodb-labs/django-mongodb-project#10