Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions django_mongodb_backend/fields/embedded_model.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import difflib

from django.core import checks
from django.core.exceptions import FieldDoesNotExist
from django.core.exceptions import FieldDoesNotExist, ValidationError
from django.db import models
from django.db.models.fields.related import lazy_related_operation
from django.db.models.lookups import Transform
Expand Down Expand Up @@ -134,8 +134,11 @@ def get_transform(self, name):

def validate(self, value, model_instance):
super().validate(value, model_instance)
if self.embedded_model is None:
return
if not isinstance(value, self.embedded_model):
raise ValidationError(
f"Expected instance of type {self.embedded_model!r}, not {type(value)!r}."
)

for field in self.embedded_model._meta.fields:
attname = field.attname
field.validate(getattr(value, attname), model_instance)
Expand Down
10 changes: 10 additions & 0 deletions tests/model_fields_/test_embedded_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,16 @@ def test_validate(self):
with self.assertRaisesMessage(ValidationError, msg):
obj.full_clean()

def test_validate_wrong_model_type(self):
obj = Holder(data=Library())
msg = (
"{'data': [\"Expected instance of type "
"<class 'model_fields_.models.Data'>, not "
"<class 'model_fields_.models.Library'>.\"]}"
)
with self.assertRaisesMessage(ValidationError, msg):
obj.full_clean()


class ModelTests(TestCase):
def test_save_load(self):
Expand Down