INTPYTHON-355 Add transaction.atomic() #357
Merged
+688
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibola
reviewed
Aug 8, 2025
django_mongodb_backend/base.py
Outdated
Comment on lines
153
to
156
| self.session = None | ||
| # Tracks if the connection is in a transaction managed by | ||
| # django_mongodb_backend.transaction.atomic. `in_atomic_block` isn't | ||
| # used in case Django's atomic() (used internally in Django) is called |
WaVEV
reviewed
Aug 9, 2025
| # The first item in the tuple (an empty list) is normally the | ||
| # savepoint IDs, which isn't applicable on MongoDB. | ||
| self.run_on_commit.append(([], func, robust)) | ||
| else: |
There was a problem hiding this comment.
Mh, elif could be use with rebuts then else for the rest.
There was a problem hiding this comment.
Copied from Django, so would rather keep it as is to make incorporating any future changes easier.
WaVEV
approved these changes
Aug 9, 2025
timgraham
force-pushed
the
atomic
branch
2 times, most recently
from
11677ed to
5bb8d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.