-
Notifications
You must be signed in to change notification settings - Fork 28
Move known-issues from topics to refs #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unconvinced that we should set a precedent of including top-level documents outside of the howto/ref/topic hierarchy. Whether it's a "topic guide' could be debated. It might be a better fit in reference material.
p.s. Please don't use such vague commit messages and PR titles as "Doc fixes".
@@ -74,5 +75,6 @@ Miscellaneous | |||
ref/index | |||
howto/index | |||
faq | |||
known-issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't follow the instructions above: .. Keep this toctree in sync with contents.rst.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? You mean the ordering?
- Looking for specific information? Try the :ref:`genindex`, :ref:`modindex`, | ||
or the detailed :doc:`table of contents <contents>`. | ||
:doc:`topics section <topics/index>` or detailed :doc:`table of contents | ||
<contents>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nor is the reference material mentioned. This text was ripped straight from Django's documentation. I don't think we need to mention every section here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to mention every section and at first I had it in its own bullet but decided to include "topics" in a bullet about topics. 😄
Also I'm only calling out personal annoyances, not necessarily looking to symmetrize the entire docs.
Lastly, copying from Django is fine but only gets us so far.
This PR addresses two issues with the documentation I've noticed: