Skip to content

INTPYTHON-733 Remove pattern matching support on non-string fields to improve performance of other queries #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

INTPYTHON-733 Remove pattern matching support on non-string fields to improve performance of other queries #372

merged 1 commit into from
Aug 22, 2025
+49 −2

Conversation

timgraham
Copy link
Collaborator

This reverts commit 5f2a094.

Jibola
Jibola approved these changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm %100 behind this. We could circle back on this another time if we had a better sense of the field's type before calling regex match. However, I don't see how that's possible here.

@timgraham timgraham changed the title Remove pattern matching support on non-string fields to improve performance of other queries INTPYTHON-733 Remove pattern matching support on non-string fields to improve performance of other queries Aug 22, 2025
@timgraham timgraham marked this pull request as ready for review August 22, 2025 21:39
@timgraham
INTPYTHON-733 Remove pattern matching support on non-string fields
f597d82 
This reverts commit 5f2a094 to improve
the performance of other queries.
@timgraham timgraham merged commit f597d82 into mongodb:main Aug 22, 2025
17 checks passed
@timgraham timgraham deleted the regex-no-tostring branch August 22, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jibola Jibola Jibola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timgraham @Jibola @blink1073